Fix swipe to vote change throws you back to the root settings page (#810)

[flx-sta]

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

• You've discussed making your changes with a member of the dev team per contributing rules in the README
• Your changes are free of any lint errors
• Your changes are free of any typescript errors
• You've tested your changes

Summary

this fixes #810

• fix the rerender upon swipeToVote change by buffering the change first
• add todo notices for missing translations

Screenshots

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-22.at.15.00.49.mp4

Test Plan

1. Go to Settings -> Appearance
2. Activate Swipe to Vote
3. Go to Feed
4. Try Voting by swiping a post -> should work
5. Go back to Settings -> Appearance.
6. Deactivate Swipe to Vote
7. Go to Feed -> Can't swipe anymore but now you can use the fullscreen "go back" gesture instead

[sgriff96]

This doesn't behave very well since if you leave the settings page before the invisible buffer takes effect, it doesn't apply the settings.

[flx-sta]

This doesn't behave very well since if you leave the settings page before the invisible buffer takes effect, it doesn't apply the settings.

You mean like when you are "super" fast with the switch and then instantly switch pages?

[sgriff96]

You mean like when you are "super" fast with the switch and then instantly switch pages?

I didn't even try to be that fast, it was like pretty casual speed imo and still didn't take effect. I can record in a min.

[flx-sta]

You mean like when you are "super" fast with the switch and then instantly switch pages?

I didn't even try to be that fast, it was like pretty casual speed imo and still didn't take effect. I can record in a min.

I believe you like that, don't worry.
Gotta think of a better solution then :/

If you have an idea feel free to tell me cause the one with leaving the page seemed reasonable

[flx-sta]

It should now get applied properly.

There is still the odd reload when changing its state and then clicking the back button in the header but I have no idea right now how to fix that as that settings affects the whole screen (all of them) due to that global gesture

[gkasdorf]

It was actually just that the whole stack was getting re-rendered on the change. I adjusted that here in this PR: #823

I copied your changes over for the locale stuff though, since I had forgotten to do that.