Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing key props #669

Merged
merged 3 commits into from
Jul 15, 2023
Merged

add missing key props #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb692a4
add missing key props
rosvik Jul 14, 2023
2aee4ee
Merge branch 'main' into rosvik/add-missing-key-props
gkasdorf Jul 15, 2023
cbf6505
Merge branch 'main' into rosvik/add-missing-key-props
gkasdorf Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/common/Search/SearchTrendingList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function SearchTrendingList({ communities }: IProps) {
<Animated.View entering={SlideInUp} exiting={SlideOutUp}>
<MTable header={t("Trending")}>
{communities.map((c) => (
<SearchCommunityItem community={c} />
<SearchCommunityItem key={c.community.id} community={c} />
))}
</MTable>
</Animated.View>
Expand Down
4 changes: 2 additions & 2 deletions src/components/screens/Search/SearchResultsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ function SearchResultsScreen({ route }: IProps) {
<ScrollView px={4}>
<MTable header={t("Users")}>
{search.result.users.map((u) => (
<SearchUserItem user={u} />
<SearchUserItem key={u.person.id} user={u} />
))}
</MTable>
</ScrollView>
Expand All @@ -79,7 +79,7 @@ function SearchResultsScreen({ route }: IProps) {
<ScrollView px={4}>
<MTable header={t("Communities")}>
{search.result.communities.map((c) => (
<SearchCommunityItem community={c} />
<SearchCommunityItem key={c.community.id} community={c} />
))}
</MTable>
</ScrollView>
Expand Down
1 change: 1 addition & 0 deletions src/components/screens/Settings/Appearance/IconSelectionScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ function IconSelectionScreen() {
<CSection footer="App icons by dizzy@lemmy.ml">
{Object.entries(appIconOptions).map(([key, value]) => (
<CCell
key={key}
cellStyle="RightDetail"
title={
<HStack space={2.5} alignItems="center">
Expand Down
2 changes: 2 additions & 0 deletions src/components/screens/Settings/Appearance/ThemeSelectionScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ function ThemeSelectionScreen({ route }: IProps) {
<CSection header={t("settings.appearance.themes.light")}>
{LightThemeOptionsArr.map((themeName) => (
<CCell
key={themeName}
cellStyle="RightDetail"
title={
<HStack space={2}>
Expand All @@ -86,6 +87,7 @@ function ThemeSelectionScreen({ route }: IProps) {
<CSection header={t("settings.appearance.themes.dark")}>
{DarkThemeOptionsArr.map((themeName) => (
<CCell
key={themeName}
cellStyle="RightDetail"
title={
<HStack space={2}>
Expand Down