Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFT_COLOR_UI_PORTRAIT #25253

Closed
wants to merge 2 commits into from

Conversation

alexgrach
Copy link
Contributor

@alexgrach alexgrach commented Jan 19, 2023

Description

TFT_COLOR_UI_PORTRAIT set fix. Tests pass fix.

Requirements

MKS Robin Nano, MKS Robin TFT 2,8"

Benefits

Configurations

Related Issues

#25207

@ellensp
Copy link
Contributor

ellensp commented Jan 22, 2023

Thinkyhead added the changes to Marlin/src/lcd/tft_io/tft_io.h into my pr #25252 which has been merged.

BUt not the other change.....

@alexgrach
Copy link
Contributor Author

_CMP doesn't work, but changing to CMP works corrently. Both changes was in #25207, but I've done something wrong I think and they was not included...

@jmz52
Copy link
Contributor

jmz52 commented Jan 26, 2023

#25279 was merged to bugfix-2.1.x
New portrait orientation check is in tft_orientation.h#L54
This PR is obsolete and can be closed

@thisiskeithb
Copy link
Member

Superseded by #25279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants