change filament issue

[Wurstnase]

make a more general solution

[boelle]

what issue does this one fix? just so i can get that one closed

[Wurstnase]

you work the hole day? ;)

Change Filament Disables X and Y Steppers Which Cuases Carriage Movement While Changing Filament #1038

msutas made a change which is realy close to my solution. I just go a little bit more general.

[boelle]

heheheh, no i'm without a job :-)

keeping this clean and moving on marlin just keeps me sane :-P

[boelle]

hmm... i never saw he submitted a pull request.... must have been sleeping :-)

[boelle]

ahh... found it, never merged thou as people are arguing back and forth....

[bkubicek]

The pull request is fine from my side, but I would prefer if the bool is
named in a more clear way, so it makes sense when you read the variable
definitions.
e.g. "inactivityStepperDisableIngore" or similar.

Bernhard

On Mon, Dec 29, 2014 at 4:38 PM, Bo Herrmannsen notifications@github.com
wrote:

hmm... i never saw he submitted a pull request.... must have been sleeping
:-)

—
Reply to this email directly or view it on GitHub
/~https://github.com/ErikZalm/Marlin/pull/1264#issuecomment-68267384.

[boelle]

@Wurstnase would that be hard to implement? or should i merge now and wait for a new pull request?

[bkubicek]

thanks

[boelle]

:-) @bkubicek what about your latest comment?

[nophead]

Why use a global variable when it can be passed as a parameter with a
default as I suggested before?

Global flags to modify behaviour like this are terrible programming
practice.and they waste ram.

On 29 December 2014 at 15:42, Bo Herrmannsen notifications@github.com
wrote:

@Wurstnase /~https://github.com/Wurstnase would that be hard to
implement? or should i merge now and wait for a new pull request?

Reply to this email directly or view it on GitHub
/~https://github.com/ErikZalm/Marlin/pull/1264#issuecomment-68267735.

[bkubicek]

@boelle he changed it Wurstnase@d1995ae
@nophead yes, thats why I proposed a default-argument for manage_inactivity. But I think this solves it for now, and can be improved later, as it fixes a bug...

[bkubicek]

@nophead Sorry, I cannot find the reference where I propsed that this can be done by a default argument. Maybe I just thought about it. I faintly remembered telling that I will change in the next few days, it, but again, I don't find this message.

So, yes, the best way would be to have manage_inactivity(disablesteppers=true) {....}.

[Wurstnase]

right! Just done it that way.

[bkubicek]

@Wurstnase thanks, I think thats even better, and also what @nophead wants, probably.
Can you please do another pull request for "Expand Manage_inactivity"?

[Wurstnase]

Sure.

[bkubicek]

thanks, i added a small change right now....