Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the required Windows-only dependencies #90

Merged
merged 2 commits into from
Nov 26, 2017
Merged

Add the required Windows-only dependencies #90

merged 2 commits into from
Nov 26, 2017

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Nov 25, 2017

Fixes #88.

@laumann
Copy link
Collaborator

laumann commented Nov 25, 2017

@dtolnay Sorry about that.

In /~https://github.com/rust-lang/rust/blob/master/src/tools/compiletest/Cargo.toml it looks like libc is always included, but that's not necessary?

@laumann
Copy link
Collaborator

laumann commented Nov 26, 2017

I'll merge this - I think you should push eb31f20 to rustc's compiletest as well.

@laumann laumann merged commit f87e35e into Manishearth:master Nov 26, 2017
@dtolnay dtolnay mentioned this pull request Nov 26, 2017
Merged
@dtolnay
Copy link
Contributor Author

dtolnay commented Nov 26, 2017

Thanks, I opened rust-lang/rust#46275 to include it upstream.

kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2017
@kennytm
Rollup merge of rust-lang#46275 - dtolnay:compiletest-libc, r=Mark-Si…
81ba352 
…mulacrum

Compiletest libc dependency can be unix-only

In main.rs libc is imported as:

```rust
#[cfg(unix)]
extern crate libc;
```

This came up in Manishearth/compiletest-rs#90.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtolnay @laumann