update to electron v34

MagicMirrorOrg · Jan 15, 2025 · e915f99 · e915f99
1 parent 6e40c44
commit e915f99
Show file tree

Hide file tree

Showing 4 changed files with 84 additions and 98 deletions.
diff --git a/.github/workflows/electron-rebuild.yaml b/.github/workflows/electron-rebuild.yaml
@@ -25,6 +25,8 @@ jobs:
         run: sudo apt-get install gpiod libgpiod2 libgpiod-dev
       - name: Install test library (node-libgpiod) to be rebuilded
         run: npm install node-libgpiod
+      - name: Fix for nan and electron rebuild as long as /~https://github.com/nodejs/nan/pull/979 is not merged
+        run: sed -i 's|^#include .nan_scriptorigin\.h.*||g' ./node_modules/nan/nan.h
       - name: Run electron-rebuild
         run: npx electron-rebuild
         continue-on-error: false
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,7 +24,7 @@ planned for 2025-04-01
 
 ### Updated
 
-- [core] Update dependencies and formatting
+- [core] Update dependencies and formatting including electron to v34
 
 ### Fixed
 

diff --git a/package-lock.json b/package-lock.json