Adds a setting for opening the folder after extracting from archive

[DaxDupont]

Greetings fellow earthlings,

I have added a setting for opening the folder after extraction.
I've never done c++ development before so any feedback is welcome if something is out of order.
Can this be marked as draft for now?

Is machine translated fine or is there a specific community process?

[MouriNaruto]

Could you also add the changes to NanaZip.UI.Classic? Thanks.

Kenji Mouri

[DaxDupont]

Could you also add the changes to NanaZip.UI.Classic? Thanks.

Kenji Mouri

Hey Kenji, This is now done.

What should I do for string translation?

[MouriNaruto]

/~https://github.com/M2Team/NanaZip/tree/main/NanaZipPackage/Strings

Maybe it can help.

Kenji Mouri

[dinhngtu]

IMO it'd be better as a per-extraction setting (in NanaZip.Windows) rather than a FM setting.

[DaxDupont]

IMO it'd be better as a per-extraction setting (in NanaZip.Windows) rather than a FM setting.

You're free to make the change but this one will work with shell extensions too, since you doing get pop-up for some of em

[DaxDupont]

/~https://github.com/M2Team/NanaZip/tree/main/NanaZipPackage/Strings

Maybe it can help.

Kenji Mouri

I've addded the Dutch one, the other languages I do not speak. Is this sufficient?

[MouriNaruto]

I'm sorry I forgot to say I hope we can add the NanaZip modification mark when modifying the 7-Zip mainline source code for better mainline synchronization maintenance which can reduce the regression. Here is an example:

NanaZip/NanaZip.Core/SevenZip/CPP/7zip/UI/Console/Main.cpp

Lines 128 to 137 in 27f148f

	// **************** NanaZip Modification Start ****************
	//static const char * const kCopyrightString = "\n7-Zip"
	// PROG_POSTFIX_2
	// " " MY_VERSION_CPU
	// " : " MY_COPYRIGHT_DATE "\n";
	static const char * const kCopyrightString = "\nNanaZip"
	PROG_POSTFIX_2
	" " MILE_PROJECT_VERSION_UTF8_STRING " (" MY_CPU_NAME ")"
	" : " "(c) M2-Team and Contributors. All rights reserved." "\n";
	// **************** NanaZip Modification End ****************

Kenji Mouri

[MouriNaruto]

/~https://github.com/M2Team/NanaZip/tree/main/NanaZipPackage/Strings
Maybe it can help.
Kenji Mouri

I've addded the Dutch one, the other languages I do not speak. Is this sufficient?

It's OK for Nana series projects. English is the only mandatory language that needs support. (Because the existence of English language resources can help the community translate into other languages.)

Kenji Mouri

[MouriNaruto]

The .rc and .h files should also add the modification mark.

Kenji Mouri

[MouriNaruto]

Please use // instead of /* */ in your .rc file changes. Thanks.

After you changed that. It looks good for me.

But I also want to know the @dinhngtu's opinion about the reply.

IMO it'd be better as a per-extraction setting (in NanaZip.Windows) rather than a FM setting.

You're free to make the change but this one will work with shell extensions too, since you doing get pop-up for some of em

Kenji Mouri

[dinhngtu]

The same setting can also be loaded into a checkbox in the Extract dialog, which would make choosing the behavior easier when trying to extract a file.

[DaxDupont]

I can make that change, can someone point me to the right cpp for it? It is somewhat hard for me to find my way around with my limited c++ and project knowledge.

[dinhngtu]

It's in SevenZip\CPP\7zip\UI\GUI\GUI.cpp.

[DaxDupont]

this is a lot more work involving editing a bunch more files since it seems to be spread over extractgui, extractdialog and it's .h/.rc and I am gonna be busy for a while, so maybe its best to mark this as draft or close it

[MouriNaruto]

I think it looks good to me to merge your current implementation. I will merge that after going off the work.

But I hope you can make that change in the future PRs.

Kenji Mouri

[MouriNaruto]

Oh, I forgot to say. The indent which the commented-out code should remain the same.

Kenji Mouri