Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally export computed properties to LW JSON #95

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

enikao
Copy link
Contributor

@enikao enikao commented Jun 14, 2024

No description provided.

@enikao enikao requested a review from dslmeinte June 14, 2024 15:24
Copy link

github-actions bot commented Jun 14, 2024

Test Results

709 tests  +4   709 ✅ +4   11s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 43ebeca. ± Comparison against base commit 35e9910.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dslmeinte dslmeinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Either type is a bit weirdly-named: I'd expect is to be named Maybe (with NONE instead of EMPTY), although there's then no corresponding Some subtype (nor does there absolutely have to be one).

@dslmeinte
Copy link
Contributor

Option instead of Maybe would also work, and might be more Java-like, but doesn't really matter.

@enikao
Copy link
Contributor Author

enikao commented Jun 17, 2024

There is an java.util.Optional type, but it has different semantics (empty if null). I don't want to confuse them.

@dslmeinte
Copy link
Contributor

There is an java.util.Optional type, but it has different semantics (empty if null). I don't want to confuse them.

Exactly, so Maybe is fine.

@enikao enikao merged commit 6fad866 into mps2021.1 Jun 17, 2024
2 checks passed
@enikao enikao deleted the niko/export-computed-properties branch June 17, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants