Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export MPS Concept alias/shortDescription to LW JSON annotation #94

Merged
merged 10 commits into from
May 28, 2024

Conversation

enikao
Copy link
Contributor

@enikao enikao commented May 27, 2024

@enikao enikao requested a review from dslmeinte May 27, 2024 21:11
@dslmeinte
Copy link
Contributor

I’m guessing this requires (the publication of) lionweb-java version 0.2.14, so I'll review after that's been published.

@ftomassetti
Copy link
Contributor

ftomassetti commented May 28, 2024

lionweb-java 0.2.14 has been released earlier today (so I tried re-starting the checks)

Copy link

github-actions bot commented May 28, 2024

Test Results

705 tests  +1   705 ✅ +1   10s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2a2b676. ± Comparison against base commit cb39ae1.

♻️ This comment has been updated with latest results.

@dslmeinte
Copy link
Contributor

dslmeinte commented May 28, 2024

OK, I updated the gradle.properties to not have -SNAPSHOT after 0.2.14, but then I still get some compile errors. I think the latest commit on lionweb-java hasn't been propagated yet.

Shall I try and fix those? They're probably renames.

@dslmeinte
Copy link
Contributor

At http://127.0.0.1:63320/node?ref=f%3Adiff_new%23r%3A6239253d-0ab2-49c2-bcf4-81f1b9a92f3e%28io.lionweb.mps.json.language%40new%29%2F3546057254294704083, addDescription seems to do two things:

  1. Introspect on the passed mps thingy.
  2. Add an annotation to the passed lw classifier with some info obtained from step 1.

Can we make that split explicit?

Copy link
Contributor

@dslmeinte dslmeinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question left as comment #94 (comment)

@enikao
Copy link
Contributor Author

enikao commented May 28, 2024

@dslmeinte
Copy link
Contributor

This url links to the temporary diff model, do you have the real one?

This works?:

http://127.0.0.1:63320/node?ref=r%3A6239253d-0ab2-49c2-bcf4-81f1b9a92f3e%28io.lionweb.mps.json.language%29%2F3546057254294704083

@enikao enikao merged commit 157c357 into mps2021.1 May 28, 2024
2 checks passed
@enikao enikao deleted the niko/export-descriptions branch May 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants