Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tree-shaking language exporter may list entities twice #91

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

enikao
Copy link
Contributor

@enikao enikao commented Mar 8, 2024

No description provided.

@enikao enikao requested a review from dslmeinte March 8, 2024 14:13
Copy link

github-actions bot commented Mar 8, 2024

Test Results

695 tests  +1   695 ✅ +1   11s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 815ee0c. ± Comparison against base commit de6b089.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dslmeinte dslmeinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The true eating of the pudding happens after migrating to 2021.3, of course.

One thing: the TestDeps-*.json files seem to be missing LionCore-builtins in their top-level languages KV-pair. (Not sure how many, but at least the new one.) Not a problem but also not according to spec. (Could fix that later in a separate PR.)

@enikao
Copy link
Contributor Author

enikao commented Mar 8, 2024

One thing: the TestDeps-*.json files seem to be missing LionCore-builtins in their top-level languages KV-pair. (Not sure how many, but at least the new one.) Not a problem but also not according to spec. (Could fix that later in a separate PR.)

Really?

For me, the first lines of solutions/io.lionweb.mps.json.test/resources/TestDeps-AvoidMultipleConcepts.json are:

{
  "serializationFormatVersion": "2023.1",
  "languages": [
    {
      "key": "LionCore-M3",
      "version": "2023.1"
    },
    {
      "key": "LionCore-builtins",
      "version": "2023.1"
    }
  ],
  "nodes": [

What's the issue there?

@dslmeinte
Copy link
Contributor

What's the issue there?

The issue I was looking at only commit 367c6524 at this point, and didn't see that commit 9112a87c fixed it. Sorry about that!

@enikao enikao merged commit 146f6f4 into mps2021.1 Mar 8, 2024
2 checks passed
@enikao enikao deleted the niko/fix-treeshaking branch March 8, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants