-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend export tests #105
base: mps2021.1
Are you sure you want to change the base?
Extend export tests #105
Conversation
9e1104e
to
fb795fa
Compare
fb795fa
to
ed7a303
Compare
Also: I think it'd be good to implement Gradle builds of the test projects, if only to show how that's done (in the same way as for T.). |
Also also: we should be able to switch on this one now: /~https://github.com/LionWeb-io/lionweb-mps/blob/meinte/extend-export-tests-2021.1/.github/workflows/build.yml#L42 (Addendum:) It does mean we have to point (from |
54cb256
to
ed7a303
Compare
We'd need to figure out how to run them as tests. But maybe in a first step it would be sufficient to just run them, and fail the build if they fail. |
@@ -44,19 +44,31 @@ task<Jar>("javadocJar") { | |||
archiveClassifier.set("javadoc") | |||
} | |||
|
|||
task<Exec>("testCmdlineExport-library") { | |||
task<Exec>("testCmdLineExport-library") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these work (on unix machines)? I think I never tried ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do run. In CI not to completion, though — see /~https://github.com/LionWeb-io/lionweb-mps/actions/runs/11139777271/job/30957126805?pr=106 —, but that's another problem. (Locally, they run — at least, for me.)
Ideally, we would run them always with SNAPSHOT, so we check changes don't break anything. Maybe we can first run |
True, and it seems we can: gradle/gradle#13337 It stands to reason that |
Also: reorganize the directory structure a little bit for clarity, and add documentation.