Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend export tests #105

Open
wants to merge 10 commits into
base: mps2021.1
Choose a base branch
from
Open

Conversation

dslmeinte
Copy link
Contributor

Also: reorganize the directory structure a little bit for clarity, and add documentation.

@dslmeinte dslmeinte requested a review from enikao October 2, 2024 06:56
@dslmeinte dslmeinte force-pushed the meinte/extend-export-tests-2021.1 branch from 9e1104e to fb795fa Compare October 2, 2024 06:58
@dslmeinte dslmeinte force-pushed the meinte/extend-export-tests-2021.1 branch from fb795fa to ed7a303 Compare October 2, 2024 07:01
@dslmeinte
Copy link
Contributor Author

Also: I think it'd be good to implement Gradle builds of the test projects, if only to show how that's done (in the same way as for T.).

Copy link

github-actions bot commented Oct 2, 2024

Test Results

0 tests   - 804   0 ✅  - 804   0s ⏱️ -11s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ❌ ±  0 

Results for commit 230ef54. ± Comparison against base commit c56025e.

♻️ This comment has been updated with latest results.

@dslmeinte
Copy link
Contributor Author

dslmeinte commented Oct 2, 2024

Also also: we should be able to switch on this one now: /~https://github.com/LionWeb-io/lionweb-mps/blob/meinte/extend-export-tests-2021.1/.github/workflows/build.yml#L42

(Addendum:) It does mean we have to point (from gradle.properties etc.) to published versions of the LionWeb MPS plugin, not 0.2.9-SNAPSHOT. It also means we first have to publish newer versions with the fixes you did, so maybe we only switch the build on after we've done that?

@dslmeinte dslmeinte force-pushed the meinte/extend-export-tests-2021.1 branch from 54cb256 to ed7a303 Compare October 2, 2024 07:40
@enikao
Copy link
Contributor

enikao commented Oct 3, 2024

Also: I think it'd be good to implement Gradle builds of the test projects, if only to show how that's done (in the same way as for T.).

We'd need to figure out how to run them as tests. But maybe in a first step it would be sufficient to just run them, and fail the build if they fail.

@@ -44,19 +44,31 @@ task<Jar>("javadocJar") {
archiveClassifier.set("javadoc")
}

task<Exec>("testCmdlineExport-library") {
task<Exec>("testCmdLineExport-library") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these work (on unix machines)? I think I never tried ...

Copy link
Contributor Author

@dslmeinte dslmeinte Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do run. In CI not to completion, though — see /~https://github.com/LionWeb-io/lionweb-mps/actions/runs/11139777271/job/30957126805?pr=106 —, but that's another problem. (Locally, they run — at least, for me.)

solutions/io.lionweb.mps.cmdline/readme.md Show resolved Hide resolved
@enikao
Copy link
Contributor

enikao commented Oct 4, 2024

It also means we first have to publish newer versions with the fixes you did, so maybe we only switch the build on after we've done that?

Ideally, we would run them always with SNAPSHOT, so we check changes don't break anything. Maybe we can first run publishToMavenLocal within the same container?

@dslmeinte
Copy link
Contributor Author

Ideally, we would run them always with SNAPSHOT, so we check changes don't break anything. Maybe we can first run publishToMavenLocal within the same container?

True, and it seems we can: gradle/gradle#13337

It stands to reason that ./gradlew publishToMavenLocal just publishes to ~/.m2/ on the virtual CI machine, after which the published package should be available. (It's also not the reason that running those tasks is currently failing in their GitHub Action.)

@dslmeinte
Copy link
Contributor Author

Screenshot 2024-10-14 at 09 17 49
I guess this should also be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants