-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle batchnorms in BatchGradientVerification #569
Conversation
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 76.97% 77.02% +0.05%
==========================================
Files 117 117
Lines 6836 6852 +16
==========================================
+ Hits 5262 5278 +16
Misses 1574 1574
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice fix
Looks like the test failures are unrelated, something to do with mnist downloads? |
Hey @indigoviolet Great work! I allowed myself to 1) add some docs to the context manager 2) rename it to hope that's ok! |
@awaelchli very nice, thank you. |
@indigoviolet mind check the failing tests? |
@Borda the test failures were unrelated to this PR, something to do with |
Now the failure seems to be something to do with mnist downloads, also unrelated to this PR. I'm not sure how to fix this (@Borda) |
Hi @indigoviolet, the tests will be fixed in #580 |
Thanks a lot @indigoviolet for working on this! |
What does this PR do?
Fixes #568
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃