Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

don't throw if readStream.destroy called more than once #83

Closed
wants to merge 1 commit into from
Closed

don't throw if readStream.destroy called more than once #83

wants to merge 1 commit into from

Conversation

mmckegg
Copy link

@mmckegg mmckegg commented Mar 1, 2013

It's too easy to accidentally call destroy on a readStream, and it's unforgiving. Had some greif when using dominictarr's map-reduce which assumes that it's safe to call.

@juliangruber
Copy link
Member

👍

@rvagg
Copy link
Member

rvagg commented Mar 1, 2013

related #82

@rvagg
Copy link
Member

rvagg commented Mar 1, 2013

btw I think the problem is a bit bigger than this because of the async end() call to the iterator. Just fiddling with alternatives to the this._status dogs-breakfast.

@rvagg
Copy link
Member

rvagg commented Mar 1, 2013

@mmckegg thanks so much for investigating this and providing a fix. Your code is fine but I'm going to close this in favour of #84 which is a little more complete (tho you're more than welcome to critique it!). I'll push out a new release in a moment that should sort this out; it'll be 0.6.1.

@rvagg rvagg closed this Mar 1, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants