Skip to content

Commit

Permalink
Merge pull request #131 from LedgerHQ/fix
Browse files Browse the repository at this point in the history
[fix] Manage 'Qt*' import error instead of 'QtCore' only
  • Loading branch information
lpascal-ledger authored May 31, 2023
2 parents 758b495 + e199dfa commit 0aa955a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).


## [1.8.1] - 2023-05-30
## [1.8.2] - 2023-05-31

### Fix
### Fixed
- import: Fix from 1.8.1 was not wide enough. Exception was filtered on 'QtCore', but they could
also throw as 'QtWidgets'.

## [1.8.1] - 2023-05-31

### Fixed
- import: Feature developed in [this branch](/~https://github.com/LedgerHQ/ragger/pull/76) forced all
Ragger installation to have PyQt5 and its dependencies installed. This is no longer the
case.
Expand Down
3 changes: 2 additions & 1 deletion src/ragger/gui/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
try:
from .process import RaggerGUI
except ImportError as e:
if e.name != "QtCore":
# Can be 'QtCore' or 'QtWidgets'
if e.name is None or not e.name.startswith("Qt"):
raise e

def RaggerGUI(*args, **kwatgs): # type: ignore
Expand Down

0 comments on commit 0aa955a

Please sign in to comment.