Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLD - NFTs Spam filtering TX #9312

Merged
merged 26 commits into from
Feb 24, 2025
Merged

LLD - NFTs Spam filtering TX #9312

merged 26 commits into from
Feb 24, 2025

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Feb 22, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

mcayuelas-ledger and others added 17 commits February 12, 2025 17:49
@mcayuelas-ledger
bugfix: reintroduce NFT spam operation in OperationsHistory
0061fb0
@mcayuelas-ledger
Review 📝
57452a7
@mcayuelas-ledger
bugfix: re-Introduce SpamTX
cda1c86
@KVNLS
feat(llm): add nft anti spam destructor in debug
69bfe84
@KVNLS
WIP
ee3c24f
@themooneer
refactor data fetching/parsing/spam detection process
3782f15
@themooneer
retro-compatibility rollback of useSpamTxFiltering and create new use…
9ddd9ae 
…FilterNftSpams for LLD only
@themooneer
while metadata are fetching, we should not retrun a filtered nft page…
01ef335 
…s of queued / loading metadata
@themooneer
code cleanup & lint
1d797ee
@mcayuelas-ledger
Add NFT tool in Developer
695f500
@themooneer
fix load more limit for last pages
14953b0
@mcayuelas-ledger
revert changes for mobile
67a0dda
@themooneer
persist nfts as spams
dca9972
@mcayuelas-ledger
Handle FF for old and new feature
041b6c5
@themooneer
fix nft operations indexing before metadata request + pagination skip…
61d0bfd 
… parameter fix
@mcayuelas-ledger
Fix simplehash tools
76c4d8c
@KVNLS
fix: tx ordering on portfolio
cf0a978
@vercel Vercel
Copy link

vercel bot commented Feb 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 11:31am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 11:31am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 11:31am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 11:31am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Feb 22, 2025
@KVNLS KVNLS changed the title Fix/spam filtering via flat pagination LLD - NFTs Spam filtering TX Feb 22, 2025
@KVNLS KVNLS marked this pull request as ready for review February 24, 2025 08:54
@KVNLS KVNLS requested a review from a team as a code owner February 24, 2025 08:54
themooneer
themooneer previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcayuelas-ledger
mcayuelas-ledger reviewed Feb 24, 2025
View reviewed changes
libs/live-nft-react/src/hooks/useSpamTxFiltering.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be changed when doing LLM

@mcayuelas-ledger mcayuelas-ledger force-pushed the fix/spam-filtering-via-flat-pagination branch from f275a4d to 0424d9e Compare February 24, 2025 11:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
23.4% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mcayuelas-ledger mcayuelas-ledger added this pull request to the merge queue Feb 24, 2025
auto-merge was automatically disabled February 24, 2025 12:50

Pull Request is not mergeable

Merged via the queue into develop with commit 7117421 Feb 24, 2025
59 of 62 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the fix/spam-filtering-via-flat-pagination branch February 24, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

@themooneer themooneer themooneer left review comments

Assignees

@KVNLS KVNLS

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KVNLS @themooneer @mcayuelas-ledger