Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blind-signing flow changes #692

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Dec 11, 2024

Description

  • hides the amount, which is usually 0 for smart-contract interactions which could give the user a false sense of safety
  • shows a transaction hash (keccak-256 of the RLP)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger merged commit ef08de1 into develop Dec 12, 2024
167 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/blind_signing_changes branch December 12, 2024 09:48
@0x398
Copy link

0x398 commented Dec 12, 2024

Please don't hide non zero amounts! It is usually zero, but I want to know when it is not. This way you hiding when some rogue smart contact want to steal ETH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants