Merge pull request #689 from LedgerHQ/misc/apa/unlink_eip712_nbgl_imp…

…lementations Unlink NBGL implementations of EIP-712 v0 and full
LedgerHQ · Dec 5, 2024 · a85de1e · a85de1e
2 parents dbcc279 + db8b202
commit a85de1e
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/src_nbgl/ui_message_signing.c b/src_nbgl/ui_message_signing.c
@@ -1,12 +1,25 @@
 #include "ui_nbgl.h"
 #include "ui_logic.h"
+#include "common_712.h"
 
-void ui_typed_message_review_choice(bool confirm) {
+static void ui_typed_message_review_choice_common(bool confirm,
+                                                  unsigned int (*approve_func)(),
+                                                  unsigned int (*reject_func)()) {
     if (confirm) {
-        ui_712_approve();
+        approve_func();
         nbgl_useCaseReviewStatus(STATUS_TYPE_MESSAGE_SIGNED, ui_idle);
     } else {
-        ui_712_reject();
+        reject_func();
         nbgl_useCaseReviewStatus(STATUS_TYPE_MESSAGE_REJECTED, ui_idle);
     }
 }
+
+void ui_typed_message_review_choice_v0(bool confirm) {
+    ui_typed_message_review_choice_common(confirm, ui_712_approve_cb, ui_712_reject_cb);
+}
+
+#ifdef HAVE_EIP712_FULL_SUPPORT
+void ui_typed_message_review_choice(bool confirm) {
+    ui_typed_message_review_choice_common(confirm, ui_712_approve, ui_712_reject);
+}
+#endif
diff --git a/src_nbgl/ui_message_signing.h b/src_nbgl/ui_message_signing.h
@@ -10,6 +10,9 @@
 #define TEXT_SIGN_EIP712       SIGN(TEXT_TYPED_MESSAGE)
 #define TEXT_BLIND_SIGN_EIP712 BLIND_SIGN(TEXT_TYPED_MESSAGE)
 
+void ui_typed_message_review_choice_v0(bool confirm);
+#ifdef HAVE_EIP712_FULL_SUPPORT
 void ui_typed_message_review_choice(bool confirm);
+#endif
 
 #endif  // UI_MESSAGE_SIGNING_H_
diff --git a/src_nbgl/ui_sign_712_v0.c b/src_nbgl/ui_sign_712_v0.c
@@ -39,5 +39,5 @@ void ui_sign_712_v0(void) {
                                    NULL,
                                    TEXT_BLIND_SIGN_EIP712,
                                    NULL,
-                                   ui_typed_message_review_choice);
+                                   ui_typed_message_review_choice_v0);
 }