Skip to content

Commit

Permalink
Merge pull request #65 from LedgerHQ/xch/app-load-params-fix
Browse files Browse the repository at this point in the history
Makefile app load params fix
  • Loading branch information
xchapron-ledger authored Nov 30, 2023
2 parents a720f0a + dd0dc57 commit 6ddc60e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 15 deletions.
11 changes: 3 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ DEFINES += HAVE_SPRINTF HAVE_SNPRINTF_FORMAT_U
DEFINES += APPVERSION=\"$(APPVERSION)\"
DEFINES += MAJOR_VERSION=$(APPVERSION_M) MINOR_VERSION=$(APPVERSION_N) PATCH_VERSION=$(APPVERSION_P)

DEFINES += UNUSED\(x\)=\(void\)x

## USB HID?
DEFINES += HAVE_IO_USB HAVE_L4_USBLIB IO_USB_MAX_ENDPOINTS=4 IO_HID_EP_LENGTH=64 HAVE_USB_APDU

Expand Down Expand Up @@ -153,12 +151,6 @@ all: default
# Build #
##############

# import generic rules from the sdk
include $(BOLOS_SDK)/Makefile.rules

#add dependency on custom makefile filename
dep/%.d: %.c Makefile

listvariants:
@echo VARIANTS COIN cardano_ada

Expand Down Expand Up @@ -203,3 +195,6 @@ format:

size: all
$(GCCPATH)arm-none-eabi-size --format=gnu bin/app.elf

# import generic rules from the sdk
include $(BOLOS_SDK)/Makefile.rules
1 change: 0 additions & 1 deletion src/io.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ unsigned short io_exchange_al(unsigned char channel, unsigned short tx_len)
return 0;
}

STATIC_ASSERT(CX_APILEVEL >= 9, "bad api level");
static const unsigned PIN_VERIFIED = BOLOS_UX_OK; // Seems to work for api 9/10

bool device_is_unlocked()
Expand Down
6 changes: 0 additions & 6 deletions src/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@
#include "uiScreens_nbgl.h"
#endif

// The whole app is designed for a specific api level.
// In case there is an api change, first *verify* changes
// (especially potential security implications) before bumping
// the API level!
STATIC_ASSERT(CX_APILEVEL >= 9, "bad api level");

static const int INS_NONE = -1;

static const uint8_t CLA = 0xD7;
Expand Down

0 comments on commit 6ddc60e

Please sign in to comment.