Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC2A-1408: Fix hardcoded path for dynamically generated c file #6

Closed
wants to merge 2 commits into from

Conversation

cedelavergne-ledger
Copy link

@cedelavergne-ledger cedelavergne-ledger commented Nov 16, 2023

The Makefile dynamically creates a c file, and its corresponding obj was hardcoded.

There is no need to declare the obj file, that will be dynamically computed by the SDK.

In addition fix the test workflow, replacing a package version.

Copy link

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev already did soemthing in the original repo to improve this : jelurida-dev@8cd928d
I think we should go for the same solution

@xchapron-ledger
Copy link

I'm wondering if this is going to cause a merge issue for #5, but if it is the case, we would be able to revert this Pr and then merge without conflicts...
What do you think about it?

@sargue
Copy link

sargue commented Nov 17, 2023

Hey, I'm not sure you're coordinating with Xavier or Victor. We just finished the security audit and changes from develop will probably merge to master soon. I would advise to wait until then to make any other changes.

@cedelavergne-ledger
Copy link
Author

Hey, I'm not sure you're coordinating with Xavier or Victor. We just finished the security audit and changes from develop will probably merge to master soon. I would advise to wait until then to make any other changes.

Hi,

No worries. I will of course wait until you have merged before re-sync my PR and fix remaining points, if any.

@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-1408_conflict-name branch January 5, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants