Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a bunch of code smells #91

Merged
merged 28 commits into from
Mar 2, 2025
Merged

Fixing a bunch of code smells #91

merged 28 commits into from
Mar 2, 2025

Conversation

InDieTasten
Copy link
Member

No description provided.

@InDieTasten
fix(code-smell): remove unread private field
f681c0a
@InDieTasten
fix(code-smell): match interface parameter name
75c0fb9
@InDieTasten
fix(code-smell): match interface parameter name
2101380 
Refs: AZFRcYUDW58op0RWG3rI
@InDieTasten
fix(code-smell): remove unread private field
fa53454 
Refs: AZFRcYTsW58op0RWG3qy
@InDieTasten
fix(code-smell): match interface parameter name
e241e2e 
Refs: AZFRcYTJW58op0RWG3ql
@InDieTasten
fix(code-smell): match interface parameter name
e499f34 
Refs: AZFRcYTJW58op0RWG3qm
@InDieTasten
fix(code-smell): match interface parameter name
d6d259a 
Refs: AZFRcYTJW58op0RWG3qn
@InDieTasten
fix(code-smell): match interface parameter default value
b652843 
Refs: AZFRcYTJW58op0RWG3qk
@InDieTasten
fix(code-smell): remove commented code
d941a11 
Refs: AZFRcYUMW58op0RWG3rU
@InDieTasten
fix(code-smell): throw specific exception type
24ac453 
Refs: AZFRcYUIW58op0RWG3rT
@InDieTasten
fix(code-smell): remove unused private set accessor
2bf8a20 
Refs: AZFRcYUIW58op0RWG3rP
@InDieTasten
fix(code-smell): remove unused private set accessor
08c9b9f 
Refs: AZFRcYUIW58op0RWG3rQ
@InDieTasten
fix(code-smell): merge nested if statements
7244edb 
Refs: AZFRcYT0W58op0RWG3q4
@InDieTasten
fix(code-smell): merge nested if statements
10dd222 
Refs: AZFRcYT0W58op0RWG3q7
@InDieTasten
fix(code-smell): change visibility of public constructor of abstract …
6c73785 
…class

Refs: AZFRcYT8W58op0RWG3rB
@InDieTasten
fix(code-smell): awaitable method should be used
0729e96 
Refs: AZFRcYUGW58op0RWG3rL
@InDieTasten
fix(code-smell): implement dispose correctly
8a8bb9b 
Refs: AZFRcYUAW58op0RWG3rG
@InDieTasten
fix(code-smell): throw specific exception type
d0c1254 
Refs: AZFRcYTwW58op0RWG3q0
@InDieTasten
fix(code-smell): do not pass caller info arguments
9148487 
Refs: AZFRcYUVW58op0RWG3rX
@InDieTasten
fix(code-smell): do not pass caller info arguments
00b7c6e 
Refs: AZFRcYUVW58op0RWG3rY
@InDieTasten
fix(code-smell): apply naming rules
5b74f03 
Refs: AZFRcYUPW58op0RWG3rV
@InDieTasten
fix(code-smell): non-derived private classes should be sealed
8055444 
Refs: AZFRcYUIW58op0RWG3rM
@InDieTasten
fix(code-smell): unassigned members should be removed
511c21b 
Refs: AZFRcYUIW58op0RWG3rN
Refs: AZFRcYUIW58op0RWG3rO
@InDieTasten
fix(code-smell): simplify loop
f60d0ec 
Refs: AZFRcYTVW58op0RWG3qq
@InDieTasten
fix(code-smell): mark serializable class as serializable
283f8b0 
Refs: AZFRcYT-W58op0RWG3rC
Refs: AZFRcYT-W58op0RWG3rD
Refs: AZFRcYT-W58op0RWG3rE
Refs: AZFRcYT-W58op0RWG3rF
@InDieTasten
fix(code-smell): apply naming rules
56a049e
@InDieTasten
chore(version): bump version
dcc7b8c
@InDieTasten
fix(code-smell): exceptionn should be public
f05d518 
Refs: AZUd5RHYN3kVWiYE935i
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@InDieTasten InDieTasten merged commit 7efbbbb into main Mar 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1fabi0 1fabi0 1fabi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InDieTasten @1fabi0