Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] adding PointLocalCoordinates and ShapeFunctionValues to triangle 3d6 #12961

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

ddiezrod
Copy link
Contributor

This PR adds two missing functions to Triangle3D6: ShapeFunctionValues and PointLocalCoordinates. Regarding the latter, we use the same approach we used in #11767 for the tetra. We check if the lines of the triangle are actually straight edges, and if so, we can use the same implementation that we use for triangle 3d3. To avoid code duplication I moved the actual implementation to geometry utils (again, same thing as we did for tets)

@ddiezrod ddiezrod requested a review from a team as a code owner December 19, 2024 15:29
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlejandroCornejo
Copy link
Member

This PR adds two missing functions to Triangle3D6: ShapeFunctionValues and PointLocalCoordinates. Regarding the latter, we use the same approach we used in #11767 for the tetra. We check if the lines of the triangle are actually straight edges, and if so, we can use the same implementation that we use for triangle 3d3. To avoid code duplication I moved the actual implementation to geometry utils (again, same thing as we did for tets)

@atfard let's see if this helps our issue (@loumalouomega we were trying to use linar conditions like 3D3N for mesh tying of quadratic tetras)

@loumalouomega
Copy link
Member

This PR adds two missing functions to Triangle3D6: ShapeFunctionValues and PointLocalCoordinates. Regarding the latter, we use the same approach we used in #11767 for the tetra. We check if the lines of the triangle are actually straight edges, and if so, we can use the same implementation that we use for triangle 3d3. To avoid code duplication I moved the actual implementation to geometry utils (again, same thing as we did for tets)

@atfard let's see if this helps our issue (@loumalouomega we were trying to use linar conditions like 3D3N for mesh tying of quadratic tetras)

A priori the proper quadratic implementation should be done, otherwise can give issues. Can work as initial approximation

@ddiezrod ddiezrod merged commit 3ddc3d6 into master Dec 23, 2024
11 checks passed
@ddiezrod ddiezrod deleted the core/adding-functions-to-triangle-3d6 branch December 23, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants