-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Reformat directory custom_conditions
using clang-format
#12433
Conversation
Hi Anne, I have not met anything strange or bad. |
applications/GeoMechanicsApplication/custom_conditions/U_Pw_face_load_interface_condition.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_conditions/U_Pw_face_load_interface_condition.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @avdg81
The code looks much cleaner and clear. I just have minor comments. But as they are repeated all over the code, I just mentioned few of them.
However, they are maybe not related to this PR as this PR focouses on clang-formatting, so they can be done in a another PR.
@@ -43,37 +42,35 @@ void PwCondition<TDim, TNumNodes>::GetDofList(DofsVectorType& rConditionDofList, | |||
} | |||
|
|||
//---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I totally agree. However, this will be addressed separately. See issue /~https://github.com/orgs/Deltares/projects/55/views/8?pane=issue&itemId=66505846.
KRATOS_CATCH( "" ) | ||
|
||
KRATOS_CATCH("") | ||
} | ||
|
||
//---------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
@@ -83,23 +80,22 @@ void PwCondition<TDim,TNumNodes>:: | |||
} | |||
|
|||
//---------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
KRATOS_CLASS_INTRUSIVE_POINTER_DEFINITION( PwCondition ); | ||
|
||
//---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
//---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
|
||
~PwCondition() override = default; | ||
|
||
//---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
//---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as comments before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
for(unsigned int i = 0; i<NumGPoints; ++i) | ||
(JContainer[i]).resize(TDim,LocalDim,false); | ||
for (unsigned int i = 0; i < NumGPoints; ++i) | ||
(JContainer[i]).resize(TDim, LocalDim, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this PR is focoused on clang-formatting, but as extra cleanup:
(JContainer[i]).resize does not need parantheses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but again, let's keep the scope of this PR clear and clean.
Variables.IntegrationCoefficient = | ||
ConditionUtilities::CalculateIntegrationCoefficient<TDim, TNumNodes>( | ||
|
||
// Obtain Np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant comments. However a such clean up of comments can be done in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
// Member Variables | ||
|
||
//---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
//---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
const Matrix& NContainer = Geom.ShapeFunctionsValues(this->GetIntegrationMethod()); | ||
GeometryType::JacobiansType JContainer(NumGPoints); | ||
for(unsigned int i = 0; i<NumGPoints; ++i) | ||
for (unsigned int i = 0; i < NumGPoints; ++i) | ||
(JContainer[i]).resize(TDim, LocalDim, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(JContainer[i]) does not need parantheses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
for(unsigned int i = 0; i<NumGPoints; ++i) | ||
(JContainer[i]).resize(TDim,LocalDim,false); | ||
for (unsigned int i = 0; i < NumGPoints; ++i) | ||
(JContainer[i]).resize(TDim, LocalDim, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not need parantheses, however, it can be done in another cleaneup PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier reply.
15ac075
to
07c3ef1
Compare
📝 Description
Reformatted directory
custom_conditions
using the clang-format tool. Also added the previous format commit to.git-blame-ignore-revs
.