-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RomApp] Adding candidate elements (and/or conditions) to HROM #11577
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
49c7fcf
Placing docstrings in the correct place
Rbravo555 8027324
adding new flag
Rbravo555 31984bd
adding initial candidate set option in ECM
Rbravo555 65a9747
Modifications on ecm to accept initial candadate set
Rbravo555 975574c
bug
Rbravo555 c2d8ce9
Adding to cpp functions to retrive elements and conditions ids
Rbravo555 1900ef7
Exporting functions to Python
Rbravo555 25da04c
ECM with candidates
Rbravo555 667e83b
Adding initial candidate sets to ECM in hrom_training_utility
Rbravo555 43c61b5
more Additions to ECM for candidate elements
Rbravo555 c828703
contemplating the case where the ECM did not converge due to initial set
Rbravo555 4d0c6d4
integers required
Rbravo555 b30eb29
RomManager changes to accept initial candidate set
Rbravo555 6960309
bug fix
Rbravo555 220b7a0
bug fix in ECM expansion of candidate set
Rbravo555 c51ad85
updating ECM test
Rbravo555 52dec05
Adding warning.
SADPR 9ab2a94
Setting defaults.
SADPR 06f3b56
Adding warnings in case some candidates entities do not contribute to R.
SADPR f6bb998
Adding warning and importing logger.
SADPR 057ce8a
Updating warnings.
SADPR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointing that these two can be easily done in parallel with an index partition.