Suggestions

KratosMultiphysics · Nov 6, 2023 · 34543ba · 34543ba
1 parent 35a6520
commit 34543ba
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/kratos/geometries/tetrahedra_3d_10.h b/kratos/geometries/tetrahedra_3d_10.h
@@ -442,7 +442,7 @@ class Tetrahedra3D10
     {
         // Using linear approximation for planar faces
         if (this->FacesArePlanar()) {
-            return GeometryUtils::PointLocalCoordinatesTetrahedra3D4N(*this, rResult, rPoint);
+            return GeometryUtils::PointLocalCoordinatesPlanarFaceTetrahedra(*this, rResult, rPoint);
         } else {
             return BaseType::PointLocalCoordinates( rResult, rPoint );
         }

diff --git a/kratos/geometries/tetrahedra_3d_4.h b/kratos/geometries/tetrahedra_3d_4.h
@@ -970,7 +970,7 @@ template<class TPointType> class Tetrahedra3D4 : public Geometry<TPointType>
         const CoordinatesArrayType& rPoint
         ) const override
     {
-        return GeometryUtils::PointLocalCoordinatesTetrahedra3D4N(*this, rResult, rPoint);
+        return GeometryUtils::PointLocalCoordinatesPlanarFaceTetrahedra(*this, rResult, rPoint);
     }
 
     /**

diff --git a/kratos/utilities/geometry_utilities.h b/kratos/utilities/geometry_utilities.h
@@ -64,12 +64,15 @@ class KRATOS_API(KRATOS_CORE) GeometryUtils
      * @return The vector containing the local coordinates of the point
      */
     template<class TGeometryType>
-    static inline typename TGeometryType::CoordinatesArrayType& PointLocalCoordinatesTetrahedra3D4N(
+    static inline typename TGeometryType::CoordinatesArrayType& PointLocalCoordinatesPlanarFaceTetrahedra(
         const TGeometryType& rGeometry,
         typename TGeometryType::CoordinatesArrayType& rResult,
         const typename TGeometryType::CoordinatesArrayType& rPoint
         )
     {
+        // Debug check that it is at least a tetrahedra
+        KRATOS_DEBUG_ERROR_IF_NOT(rGeometry.GetGeometryFamily() == GeometryData::KratosGeometryFamily::Kratos_Tetrahedra) << "Geometry should be a tetrahedra in order to use PointLocalCoordinatesPlanarFaceTetrahedra" << std::endl;
+
         // Compute RHS
         array_1d<double,4> X;
         X[0] = 1.0;