Feature/json handler consumer factory #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
============================================
+ Coverage 91.61% 91.78% +0.16%
- Complexity 1530 1543 +13
============================================
Files 144 144
Lines 6287 6387 +100
Branches 170 172 +2
============================================
+ Hits 5760 5862 +102
+ Misses 435 432 -3
- Partials 92 93 +1
Continue to review full report at Codecov.
|
marcinus
reviewed
Mar 31, 2020
.../api/src/main/java/io/knotx/fragments/handler/consumer/api/FragmentExecutionLogConsumer.java
Outdated
Show resolved
Hide resolved
handler/core/src/test/java/io/knotx/fragments/handler/consumer/MetadataConverterTest.java
Outdated
Show resolved
Hide resolved
handler/core/src/test/java/io/knotx/fragments/handler/consumer/EventLogConverterTest.java
Show resolved
Hide resolved
.../main/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactory.java
Outdated
Show resolved
Hide resolved
.../main/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactory.java
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
marcinus
reviewed
Apr 2, 2020
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
tomaszmichalak
requested changes
Apr 7, 2020
.../main/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactory.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/knotx/fragments/handler/consumer/json/JsonFragmentsHandlerConsumerFactoryTest.java
Outdated
Show resolved
Hide resolved
tomaszmichalak
requested changes
Apr 8, 2020
...er/api/src/main/java/io/knotx/fragments/handler/consumer/api/model/FragmentExecutionLog.java
Outdated
Show resolved
Hide resolved
handler/core/src/test/resources/task/factory/taskWithNodeLabels.conf
Outdated
Show resolved
Hide resolved
|
Please create/update README :) |
tomaszmichalak
force-pushed
the
feature/json-handler-consumer-factory
branch
from
feda2ae to
fb56b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #134.
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.