fix: handle empty value returned by getSemanticHTML #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression was spotted by our team when updating to the lastest ngx-quill version, where required form controls applied on quill editors were no longer be marked invalid when emptied.
It looks like `getSemanticHTML()` can return `<p></p>` when the editor is emptied (at least when it is emptied programatically using `setText('')`).
This commit augments the "empty" check to handle this possible value and `<div></div>`.
A unit test has been added to reproduce this issue.
KillerCodeMonkey
approved these changes
Apr 23, 2024
|
@cexbrayat thanks i had this on my todo list as next bullet point to solve :D, because i saw this in in my demo repo, that the empty handling changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was spotted by our team when updating to the lastest ngx-quill version, where required form controls applied on quill editors were no longer be marked invalid when emptied.
It looks like
getSemanticHTML()can return<p></p>when the editor is emptied (at least when it is emptied programatically usingsetText('')). This commit augments the "empty" check to handle this possible value and<div></div>. A unit test has been added to reproduce this issue.