Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing angle conversions in PGFPlotsX #4703

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Missing angle conversions in PGFPlotsX #4703

merged 5 commits into from
Mar 24, 2023

Conversation

ivan-boikov
Copy link
Contributor

@ivan-boikov ivan-boikov commented Mar 23, 2023

Description

Fixes #3266 (fully) #1007 (partially)
Also added heatmap transparency to see axes in figures below.

Testing code
pgfplotsx()

angles = collect(range(0, 2π, length = 6))
radius = [10, 10, 10, 14, 19, 10]
plot(angles, radius, proj = :polar, fill = (0, :orange, 0.5), lc=:orange, legend=:none, 
    title="#3266", size=(300,300))

theta = range(0,2π; length=60);
rho = range(0.1, 5; length=4);
z = rho .* theta';
heatmap(theta, rho, z, proj=:polar, c=:jet, alpha=0.8, title="#1007", size=(300,300))

Before fix
image image

After fix
image image

Attribution

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.03 ⚠️

Comparison is base (fbdaa89) 90.42% compared to head (0598035) 90.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4703      +/-   ##
==========================================
- Coverage   90.42%   90.40%   -0.03%     
==========================================
  Files          40       40              
  Lines        8719     8721       +2     
==========================================
  Hits         7884     7884              
- Misses        835      837       +2     
Impacted Files Coverage Δ
src/backends/pgfplotsx.jl 88.27% <66.66%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivan-boikov ivan-boikov changed the title Missing angle conversion in filled polar plot in PGFPlotsX Missing angle conversions in PGFPlotsX Mar 23, 2023
@BeastyBlacksmith BeastyBlacksmith merged commit 4400dba into JuliaPlots:master Mar 24, 2023
@ivan-boikov ivan-boikov deleted the ib-pgfx-polar-fill branch March 24, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PGFPlotsX bug in Polar plot with argument fill[BUG]
2 participants