Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for configuring managed identities; #142 #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

druttka
Copy link

@druttka druttka commented Mar 28, 2023

We needed the same functionality requested in #142 and would like to contribute that back. Please let me know if there are any questions or requested changes. Hope it helps. Thanks!

@druttka druttka force-pushed the issue-142/managed-identity branch from 9b4d76c to ef137f1 Compare March 28, 2023 16:53
@druttka druttka marked this pull request as draft March 28, 2023 17:38
@druttka druttka force-pushed the issue-142/managed-identity branch from ef137f1 to 3711b5f Compare March 28, 2023 17:45
@druttka druttka marked this pull request as ready for review March 28, 2023 17:45
@druttka
Copy link
Author

druttka commented May 1, 2023

Hi @wayfarer-rus and @IlyaFomenko. I noticed that you have recent activity in this repo, so I was hoping you could point me in the right direction for getting this reviewed. It's to help with issue #142 , as my team ran into the same need and are happy to contribute back what worked for us. Thanks!

Copy link

@AmieDD AmieDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thanks for making the changes @druttka

@steve-watson
Copy link

steve-watson commented Aug 18, 2023

@yaegor @Leonya Has there been any movement on this? Happy to post on the TeamCity support under our studio account as well if needed, but this seems the better place.

@steve-watson
Copy link

steve-watson commented Sep 26, 2023

@yaegor @Leonya @wayfarer-rus @IlyaFomenko Can anyone please point me in the right direction of who owns this maybe? The initial request/comment was over 5 months ago...

@alwaysharsha
Copy link

@yaegor The Managed Identity feature would be very beneficial, is that something your team can look and support it?

@sugdyzhekov
Copy link

We are working on a brand new plugin based on actual Azure SDK. The initial release is expected till the end of the year. This feature is planned as part of the new plugin. Sorry for delay and any inconveniences.

@steve-watson
Copy link

Fantastic, thank you! it has worked really well for us so far with this change.

Cheers

@steve-watson
Copy link

steve-watson commented Jan 8, 2025

@sugdyzhekov @IlyaFomenko @yaegor @wayfarer-rus

Have there been any updates to this? It has been 15 months since there was a note about a new version (22 months since we submitted it) and we see there is in fact a new version, but it does not support the managed identities still, so the new version blocks us completely as it removed the Identity at deploy it seems which means out VMs never come online in TeamCity.

I was hoping in that 15 months there would be some update from JetBrains as it was noted by @sugdyzhekov mentioned "This feature is planned as part of the new plugin."

Any info would be appreciated

@cheshirrrr
Copy link

@steve-watson Hi!

There were some unfortunate delays in the development, but we are still working on the new plugin and are planning to release it.

Just to clarify: it will be a brand new plugin, with it's own codebase and it's own repo. You can follow the progress here:
https://youtrack.jetbrains.com/issue/TW-83875/Azure-cloud-agents

As for this issue: due to some recent commits we made this code now has conflicts, but we appreciate all the work you did and see that this feature is needed, so we will integrate this feature into our code and fix all the conflicts ourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants