[WIP] PlatformTextInputService2 #1853
Conversation
m-sasha
force-pushed
the
m-sasha/text-input-service-2
branch
from
a22af3e to
d303828
Compare
| updateTextFieldValue(newValue.toTextFieldValue()) | ||
| val outputValueFlow = callbackFlow { | ||
| state.collectImeNotifications { oldValue, newValue, restartIme -> | ||
| println("IME Notification: oldValue=$oldValue, newValue=$newValue, restartIme=$restartIme") |
There was a problem hiding this comment.
Remove or wrap into some private debug flag
| * If there aren't enough codepoints in the correct direction, returns 0 (if [offset] is negative) | ||
| * or the length of the char sequence (if [offset] is positive). | ||
| */ | ||
| private fun CharSequence.indexOfCodePointAtOffset(index: Int, offset: Int): Int { |
There was a problem hiding this comment.
Not obvious logic, it's better to cover this function with tests separately
| fun setComposingText(text: CharSequence, newCursorPosition: Int) | ||
| } | ||
|
|
||
| interface PlatformTextInputService2 { |
There was a problem hiding this comment.
All public APIs should be covered by KDocs
| // | ||
| // continuation.invokeOnCancellation { | ||
| // textInputService.stopInput() | ||
| // } |
There was a problem hiding this comment.
Remove commented code before the merge
| import androidx.compose.ui.geometry.Rect | ||
| import androidx.compose.ui.text.TextRange | ||
|
|
||
| interface TextEditorState : CharSequence { |
There was a problem hiding this comment.
Do we want to make it stable from the start?
m-sasha
force-pushed
the
m-sasha/text-input-service-2
branch
from
d303828 to
56c4edb
Compare
| private fun TextFieldCharSequence.asTextEditorState() = object : TextEditorState { | ||
|
|
||
| override val length: Int | ||
| get() = this@asTextEditorState.length |
There was a problem hiding this comment.
why we need to override this?
There was a problem hiding this comment.
This whole wrapper is because TextFieldCharSequence is in foundation, but PlatformTextInputService(2) is in ui. So foundation needs to wrap it in an interface that's available in ui.
| override val composition: TextRange? | ||
| get() = this@asTextEditorState.composition | ||
|
|
||
| } |
There was a problem hiding this comment.
the same question about all overrides - I miss the context - for me this looks like redundant delegation - why we are doing this?
This is a WIP PR for transitioning the implementation of BTF2 away from using
PlatformTextInputServiceandTextFieldValue.