CfW: Fix Clipboard events handling for BasicTextField2 #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
changed the title
Schahen
approved these changes
Jan 24, 2025
MatkovIvan
reviewed
Jan 29, 2025
| @@ -294,6 +294,14 @@ internal fun BasicTextField( | |||
| val currentClipboardManager = LocalClipboardManager.current | |||
| val currentTextToolbar = LocalTextToolbar.current | |||
| val autofillManager = LocalAutofillManager.current | |||
|
|
|||
| rememberClipboardEventsHandler( | |||
There was a problem hiding this comment.
Should we do it in AOSP first? Do we have YT item to upstream it later?
There was a problem hiding this comment.
Add a comment in the code
https://youtrack.jetbrains.com/issue/CMP-7517/Upstream-rememberClipboardEventsHandler
eymar
force-pushed
the
ok/cmp-7435-fix-btf2-clipboard-events
branch
from
2e095a2 to
f09d355
Compare
|
This change doesn't affect desktop target (the actual implementation of a new internal method is NoOp), so the failing tests can't be related to the change. Therefore, I'm merging this PR despite the failing desktop tests (the failing tests are about lifecycle - not related to BTF2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CMP-7435
Release Notes
Fixes - Web
BasicTextFieldhandles browser copy/cut/paste events correctly now. Previously, they were ignored.