-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added GitHub workflow and other enhancements #8
Conversation
…Windows and Linux binaries using "windows-latest" and "ubuntu-latest" resulted in non-working library files
did not have to do this in local docker tests
previous experiments resulted in unusable/corrupted DLL/SO files
…S binaries this makes it more easy to run "in parallel" and removes the need for many IF-conditions in action-steps
…/SO files otherwise
see godotengine/godot-cpp#1518 for more details
found this trick by checking godotengine/godot-cpp#1518 again for solutions by others
these files are generated using SCons
I tried to add good comments and references across my changes, hopefully they help. |
Okay, found the issue .... and it's somewhat unexpected, EDIT: I found godotengine/godot#75472 which points to the @JekSun97 as this is your gdExtension ... do you prefer the name "Tree3D" or are you okay with "gdTree3D"? |
@FibreFoX Thanks for the work done on GitHub Action! For me this is a particularly complex and unexplored topic :D I would like to keep the name "Tree3D" instead of "gdTree3D" as it matches the naming of nodes in Godot Engine, I used gd at the beginning of the name so people would understand that it is related to Godot, maybe I should correct this confusion in README.md |
@JekSun97 I am more used to GitLab, so using GA was an adventure for me too ;) Regarding the name: sure, will change it, please wait some time for the changes before merging ;) I will change the README accordingly, will be part of my changes (less for you to do :D) |
@JekSun97 I think my changes are complete now, please verify that my changes are working for you. Here the link to the workflow for my last commit (you can find the binaries there): /~https://github.com/FibreFoX/gdTree3D/actions/runs/10656732794 EDIT: of course I had to fix the icon again ;) |
Thank you! |
@JekSun97 just remember, when creating a git-tag, there will be automatically a draft-release created ;) no more manually adding the files |
Are they built from the main branch? is the workflow like this?:
Will the release contain all the built dll files for the operating systems? |
@JekSun97 Just saw the new release ;) the created draft-release already contained different ZIP files, which contained the complete addon and the demo-projects. Did you not use them on purpose? |
Tiny note: I see that you are not using proper git tags, please only use anything that starts with |
@FibreFoX I was a bit hasty and as usual got confused in all this :D, for the next release, before its release, I will need to contact you for step-by-step instructions. |
This should fix #3 (for real this time).
Small overview what this PR improves:
compatibility_minimum
version)gdTree3D
, because it was confusing sometimes (even was mentioned in the video https://www.youtube.com/watch?v=4aPkTQuo53E where this Godot extension was mentioned), except the generated library filename (could not figure it out)Details about the Github Actions workflow:
Artifacts can only be downloaded when being logged into some Github account (seems to be a quite new restriction, there is an open issue, which I forgot to bookmark). Checking for it can be reached via the navigation, where all the workflows then are listed:
The draft release is created when a git-tag is created starting with the letter
v
(e.g.v1.0.0
), and can be found in the sidebar navigation:Important: I do not have access to any Apple Silicon/Apple-ARM-CPU system, where I could check the "Universal 2"-MacOS-binary. If this is faulty (like I had problems with all the 64bit binaries before, see #5 (comment)), just ping me, so I can fix it fast.
I tried to not change too much, and did add a lot of commits (sorry for the commit noise). But I had a ton of fun creating this workflow.
If there are any more changes, feel free to contact me, or write me here via this PR.