Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge identical group colors #6491

Closed
wants to merge 14 commits into from
Closed

Merge identical group colors #6491

wants to merge 14 commits into from

Conversation

WangAooa
Copy link
Contributor

@WangAooa WangAooa commented May 18, 2020

Fixes #6175

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at /~https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@WangAooa WangAooa mentioned this pull request May 18, 2020
5 tasks
@calixtus calixtus changed the title fix 6175 Merge identical group colors May 19, 2020
@calixtus
Copy link
Member

calixtus commented May 19, 2020

Thanks for the update. Next time, please reuse the existing PR as otherwise we are loosing track of all the PRs. Please fix the remaining checkstyle issues, then we can review this.
Edit: On the other hand, this is already on review 😉

@calixtus calixtus marked this pull request as draft May 19, 2020 12:02
@calixtus calixtus marked this pull request as ready for review May 19, 2020 12:07
@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: changes required Pull requests that are not yet complete labels May 19, 2020
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Your solution looks good. It might be a bit more readable, however, if you instead use Stream.distinct in /~https://github.com/JabRef/jabref/pull/6491/files#diff-3550abce7f352ea1c73ed2c0e0e0dd37R181. Could you please try if this works indeed. I guess it would be good to add distinct also in the calculation of matchedGroupsString further below.

@WangAooa WangAooa closed this May 27, 2020
@calixtus
Copy link
Member

Was closing this PR intentional?

@calixtus calixtus mentioned this pull request Jun 1, 2020
5 tasks
calixtus added a commit that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes required Pull requests that are not yet complete status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group color, only display identical colors once
3 participants