-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge identical group colors #6491
Conversation
Thanks for the update. Next time, please reuse the existing PR as otherwise we are loosing track of all the PRs. Please fix the remaining checkstyle issues, then we can review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Your solution looks good. It might be a bit more readable, however, if you instead use Stream.distinct
in /~https://github.com/JabRef/jabref/pull/6491/files#diff-3550abce7f352ea1c73ed2c0e0e0dd37R181. Could you please try if this works indeed. I guess it would be good to add distinct
also in the calculation of matchedGroupsString
further below.
Was closing this PR intentional? |
Fixes #6175