Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test_mmap on net8.0/POSIX #1860

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Jan 4, 2025

Establishing a mmap test from StdLib on POSIX to prevent unnoticed regressions from #1855.

The test does not pass on .NET 6.0, which has problems with mmaps not backed by an existing file. A workaround is possible, but likely quite tricky to get it right (i.e. w/o data leaking). I don't think it is worth the effort given that .NET 6.0 is now past its EOL.

The case of Mono seems hopeless; it dumps core when running this test.

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slozier slozier merged commit 97fc78a into IronLanguages:main Jan 4, 2025
6 of 8 checks passed
@BCSharp BCSharp deleted the mmap_test branch January 6, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants