Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_open_abplus #1851

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Update test_open_abplus #1851

merged 2 commits into from
Dec 25, 2024

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Dec 24, 2024

Using raw better represents what this test is supposed to test — unbuffered access.

@BCSharp BCSharp mentioned this pull request Dec 24, 2024
Open
slozier
slozier approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BCSharp BCSharp merged commit 8aaa27b into IronLanguages:main Dec 25, 2024
8 checks passed
@BCSharp BCSharp deleted the open_abplus_raw branch December 25, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slozier slozier slozier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BCSharp @slozier