Drop dependency on cardano-prelude
#4841
Merged
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/remove-usage-of-cardano-prelude
branch
from
ba003e0 to
e874b9b
Compare
Reflect usage of `unsafeIndex` with the bounds of `bytestring`. `bytestring-0.11.3.0` was accidentally released with `unsafeIndex` hidden from the export list. This issues was promptly fixed in `bytestring-0.11.4.0`. So, we just need to exclude the affected version in cabal file instead of rely on some custom implementation of the function in a package that we don't normally use in ledger.
lehins
force-pushed
the
lehins/remove-usage-of-cardano-prelude
branch
from
e874b9b to
8105bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bytestring-0.11.3.0was accidentally released withunsafeIndexhidden from the export list. This issues was promptly fixed inbytestring-0.11.4.0. So, we just need to exclude the affected version in cabal file instead of rely on some custom implementation of the same function in a package that we don't normally use in ledger.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)