Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trans watchface #2201

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Aperture32GLaDOS
Copy link

Adds a new watch face with the trans flag as a background

Features

  • A new watch face, featuring the trans flag
  • Bluetooth indicator in the top right
  • Long day names

Images

image

Copy link

github-actions bot commented Dec 16, 2024

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

@mark9064 mark9064 added the new watchface This thread is about a new watchface label Dec 22, 2024
@marigoldfish
Copy link

marigoldfish commented Dec 30, 2024

Love it! 🏳️‍⚧️😁 You are a very cool person, I'm going to be using this for a while!

Edit to add: I hope you find $20 on the ground or something similar fortunate and nice happens to you!

IMG_20241229_213604426~2

Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

src/displayapp/screens/WatchFaceTrans.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/WatchFaceTrans.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/WatchFaceTrans.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/WatchFaceTrans.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/WatchFaceTrans.h Outdated Show resolved Hide resolved
@Aperture32GLaDOS
Copy link
Author

Thanks for the quick feedback! I've implemented those changes, hopefully everything's good now

@mark9064
Copy link
Member

mark9064 commented Jan 3, 2025

All looks good to me! You couldn't have made review easier :)

I haven't had the chance to test on hardware yet and am away for now, but I should be able to test within a couple weeks time

@mark9064 mark9064 added this to the 1.16.0 milestone Jan 3, 2025
@marigoldfish
Copy link

I have been using this daily, and I really like it, but I have a few small suggestions:

I adore the "You have mail." for notifications, but I dislike that it overlaps so severely with the battery percentage:

IMG_20241231_082654043~2

I think it might look better to have "mail." on its own line below, and move "You have" up a little bit so they're both centered vertically in the blue stripe.

(The 90's kid in me really wants it to read "You've got mail," like AOL, but that's not a request for a change, just a nostalgic observation)

My other suggestion is to name the watch face more specifically as "Trans Flag" instead of just "Trans."

IMG_20250103_220544316_HDR~2

Like I said, very very small suggestions. The other 99% of this watchface is grand!

@Aperture32GLaDOS
Copy link
Author

I definitely agree with the notification and the name. Fortunately, these are just one-line fixes so it's not that hard to change.
image

Copy link

@marigoldfish marigoldfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I can nitpick, I think "Mail" should be lowercase. But this looks really good 😁

@Aperture32GLaDOS
Copy link
Author

Good spot, I'll fix that

@marigoldfish
Copy link

You are an incredibly awesome and speedy person! Thanks for implementing my suggestions, and so fast! I'll keep testing this daily for a while and let you know if I come across anything else 😁

@marigoldfish
Copy link

Hello again, I noticed another little thing after using this watch face for a while.

Usually I keep my watch in 24 hour time, but I had reason to use 12 hour time today, and I noticed that both AM and PM show up as "M."

(I manually set the watch to 2am to get the second picture, I didn't stay up late 😜)

IMG_20250117_184147295~2
IMG_20250117_184236513~3

@Aperture32GLaDOS
Copy link
Author

I think what's happening here is that the font used for the time doesn't have all the alphabet, if I change the font to something else it seems to work fine:
image
I've moved the AM/PM display to the day, since that uses a font which has all the alphabet
image

@marigoldfish
Copy link

That's an elegant fix! I like it!

Unfortunately, in addition to praise I also come bearing news of a new bug: it is displaying 24-hour time when I have 12-hour time enabled.

IMG_20250119_203002810~2

@Aperture32GLaDOS
Copy link
Author

Aah, well at least that's an easy fix; it should all be working now
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new watchface This thread is about a new watchface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants