Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed for autovalidation (#2225) #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ljahn
Copy link
Contributor

@ljahn ljahn commented Jan 12, 2025

These are some fixes for the simulator if InfiniTimeOrg/InfiniTime#2225 gets merged in InfiniTime

@@ -19,3 +19,5 @@ void FirmwareValidator::Validate() {
void FirmwareValidator::Reset() {
// NVIC_SystemReset();
}

void FirmwareValidator::AutoValidate() {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Mike newlines at the enf of a file to prevent the red stop signs in the diff viewer of github

Suggested change
void FirmwareValidator::AutoValidate() {}
void FirmwareValidator::AutoValidate() {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-InfiniTime-change PR blocked until InfiniTime upstream change is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants