fix(credentials): add partnerId on getCredentialsRoles #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntial, because it is the one that is in the context and used during getCredential" This reverts commit 36d5154.
jggrimal
force-pushed
the
fix/#138-add-partner-id-on-get-credentials-roles
branch
from
aa0571d to
4c1910b
Compare
lilgallon
requested changes
Oct 31, 2024
Comment on lines
29
to
30
| partnerRepository.getPartnerIdByCredentialsServerToken(token) | ||
| ?: throw OcpiClientInvalidParametersException("Invalid ServerToken ($token)"), |
There was a problem hiding this comment.
tokenA is allowed for credentials module (see PartnerRepository.checkToken in HttpUtils)
Suggested change
| partnerRepository.getPartnerIdByCredentialsServerToken(token) | |
| ?: throw OcpiClientInvalidParametersException("Invalid ServerToken ($token)"), | |
| partnerRepository.getPartnerIdByCredentialsServerToken(token) | |
| ?: partnerRepository.getPartnerIdByCredentialsTokenA(credentialsTokenA = token) | |
| ?: throw OcpiClientInvalidParametersException( | |
| "Invalid token ($token) - should be either a TokenA or a ServerToken", | |
| ), |
jggrimal
force-pushed
the
fix/#138-add-partner-id-on-get-credentials-roles
branch
from
4c1910b to
e6440a4
Compare
jggrimal
force-pushed
the
fix/#138-add-partner-id-on-get-credentials-roles
branch
from
e6440a4 to
ccdef49
Compare
|
lilgallon
approved these changes
Oct 31, 2024
lilgallon
deleted the
fix/#138-add-partner-id-on-get-credentials-roles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review the #138 fix