Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to summary keyboard in calculator #9456

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

Fidel365
Copy link
Contributor

Fixes partially #9440
@rdstern I saw to do this, on the calculator part, it's ready for review.

@rdstern
Copy link
Collaborator

rdstern commented Feb 24, 2025

@Fidel365

a) The keyboard layout is fine. Well done.
b) But look below:

image

you have included the name of the data frame after x = .
Instead it should be blank and with the cursor there, so the correct variable can be included.

This is both for quantile and quantile3.
And can you make the tooltip a bit shorter. So: for the variable, from the ggplot2 diamonds, gives

@Fidel365
Copy link
Contributor Author

@rdstern ready once more.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 that's great. Thanks
@N-thony please can you check, and I hope approve. Vice, bvital to include this in the release.

@N-thony N-thony merged commit 2063096 into IDEMSInternational:master Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants