-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add override for jsonpath-plus to avoid CVE #729
Conversation
@@ -45,8 +45,8 @@ | |||
"coverageDirectory": "./coverage/", | |||
"testEnvironment": "node", | |||
"moduleNameMapper": { | |||
"nimma/legacy": "<rootDir>/../../node_modules/nimma/dist/legacy/cjs", | |||
"nimma/fallbacks": "<rootDir>/../../node_modules/nimma/dist/cjs/fallbacks/" | |||
"nimma/legacy": "<rootDir>/../../node_modules/@stoplight/spectral-core/node_modules/nimma/dist/legacy/cjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding the override and running npm install
, a bunch of tests failed due to the fact that nimma was no longer available at the same location. It's now located within the spectral-core's own node_modules directory for some reason. Modifying these mapper entries seemed to let all the tests run clean.
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@@ -15,6 +15,7 @@ module.exports = { | |||
{ | |||
singleQuote: true, | |||
arrowParens: 'avoid', | |||
trailingComma: 'es5', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We effectively have moved up to prettier v3.x with this PR, so I set trailingComma to the v2.x default value ("es5") to avoid lots of commas being added to lots of files 😂
testDocument.components.requestBodies[ | ||
'UpdateCarRequest' | ||
].required = false; | ||
testDocument.components.requestBodies['UpdateCarRequest'].required = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one formatting change that resulted from bumping prettier v2.x -> v3.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
## @ibm-cloud/openapi-ruleset-utilities [1.7.1](/~https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset-utilities@1.7.0...@ibm-cloud/openapi-ruleset-utilities@1.7.1) (2025-02-12) ### Bug Fixes * **build:** add override for jsonpath-plus to avoid CVE ([#729](#729)) ([ef4f34d](ef4f34d))
🎉 This PR is included in version 1.7.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
## @ibm-cloud/openapi-ruleset [1.29.2](/~https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.29.1...@ibm-cloud/openapi-ruleset@1.29.2) (2025-02-12) ### Bug Fixes * **build:** add override for jsonpath-plus to avoid CVE ([#729](#729)) ([ef4f34d](ef4f34d)) ### Dependencies * **@ibm-cloud/openapi-ruleset-utilities:** upgraded to 1.7.1
🎉 This PR is included in version 1.29.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
## ibm-openapi-validator [1.33.2](/~https://github.com/IBM/openapi-validator/compare/ibm-openapi-validator@1.33.1...ibm-openapi-validator@1.33.2) (2025-02-12) ### Bug Fixes * **build:** add override for jsonpath-plus to avoid CVE ([#729](#729)) ([ef4f34d](ef4f34d)) ### Dependencies * **@ibm-cloud/openapi-ruleset:** upgraded to 1.29.2 * **@ibm-cloud/openapi-ruleset-utilities:** upgraded to 1.7.1
🎉 This PR is included in version 1.33.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
No description provided.