fix(ibm-major-version-in-path): skip path checks if there are no paths #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule checks both the `servers` entries and the path strings in an API definition. If an API definition contains no path strings in the `paths` object, this rule would return a false positive. This adds logic to skip the path string checks if there are none to check. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
Signed-off-by: Dustin Popp <dpopp07@gmail.com>
dpopp07
force-pushed
the
dp/tolerate-lack-of-paths
branch
from
0d061dd to
34188fb
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Feb 7, 2025
## @ibm-cloud/openapi-ruleset [1.29.1](/~https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.29.0...@ibm-cloud/openapi-ruleset@1.29.1) (2025-02-07) ### Bug Fixes * **ibm-major-version-in-path:** skip path checks if there are no paths ([#727](#727)) ([c539741](c539741))
|
🎉 This PR is included in version 1.29.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.33.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule checks both the
serversentries and the path strings in an APIdefinition. If an API definition contains no path strings in the
pathsobject, this rule would return a false positive. This adds logic to skip
the path string checks if there are none to check.
I also renamed a file to better match the rule name.