fix(ibm-use-date-based-format): handle null example values #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the example value given for a property was an explicit 'null', this rule would crash the validator. This commit filters null examples from the logic so that they won't cause any trouble. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
dpopp07
added a commit
that referenced
this pull request
Feb 4, 2025
Previously, if the example value given for a property was an explicit 'null', this rule would crash the validator. This commit filters null examples from the logic so that they won't cause any trouble. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Feb 4, 2025
# @ibm-cloud/openapi-ruleset [1.29.0](/~https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.28.4...@ibm-cloud/openapi-ruleset@1.29.0) (2025-02-04) ### Bug Fixes * **ibm-use-date-based-format:** avoid false positives for mac addresses ([#723](#723)) ([357dfb2](357dfb2)) * **ibm-use-date-based-format:** handle null example values ([#724](#724)) ([e096b12](e096b12)) ### Features * **ibm-valid-schema-example:** introduce new validation rule ([d2f8071](d2f8071))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the example value given for a property was an explicit 'null', this rule would crash the validator.
This commit filters null examples from the logic so that they won't cause any trouble.