Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thefuck 3.31 #79039

Closed
wants to merge 1 commit into from
Closed

thefuck 3.31 #79039

wants to merge 1 commit into from

Conversation

scorphus
Copy link
Contributor

@scorphus scorphus commented Jun 9, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

New releaase fixes a vulnerability.

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jun 9, 2021
@nandahkrishna
Copy link
Member

nandahkrishna commented Jun 9, 2021

@scorphus it seems like a few resources need updates here. Could you use brew update-python-resources thefuck to do this, and squash the changes with your existing commit?

Oh also, you have to remove the revision line.

Note: Using brew bump-formula-pr will do this automatically for you, and all you have to do (usually) is specify --version <VERSION> and the formula name.

@scorphus
Copy link
Contributor Author

scorphus commented Jun 9, 2021

brew bump-formula-pr --strict thefuck --version=3.31 didn't work for me:

Error: You need to bump this formula manually since the new URL
and old URL are both:
  https://files.pythonhosted.org/packages/21/d2/f5194c2d51b2aab4bda6de97c5eb1ca5a547ad9b9f778ab5bf4ce19fba88/thefuck-3.31.tar.g

What am I doing wrong?

@nandahkrishna
Copy link
Member

I should've also mentioned that the command is used to create new PRs, and not for this one. That was meant to be for your next contribution 😅

@scorphus
Copy link
Contributor Author

scorphus commented Jun 9, 2021

Yeah, I meant that I tried with bump-formula-pr before doing it manually.

New releaase fixes a [vulnerability][1].

[1]: nvbn/thefuck#1206
@nandahkrishna
Copy link
Member

It seems like you updated the URL before you ran bump-formula-pr, hence the error. The command should be run without making any modifications to the formula.

@scorphus
Copy link
Contributor Author

scorphus commented Jun 9, 2021

That wasn't the case. But it should be reproducible until this PR is not accepted, right?

Anyways, hopefully that last push has it all. And I'll try bump-formula-pr again in the next release — by then I hope I'll be a bit luckier. 😄

Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scorphus
Copy link
Contributor Author

scorphus commented Jun 9, 2021

Thanks for the help, @nandahkrishna 👍

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@scorphus scorphus deleted the thefuck-3.31 branch June 9, 2021 22:43
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants