Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thefuck 3.23 #17347

Closed
wants to merge 1 commit into from
Closed

thefuck 3.23 #17347

wants to merge 1 commit into from

Conversation

DomT4
Copy link
Contributor

@DomT4 DomT4 commented Aug 29, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Upstream are getting murdery towards python2 support, and new features require python3, so.

@ilovezfs
Copy link
Contributor

ilovezfs commented Aug 29, 2017

Passing on this until they actually drop python2 support completely.

@ilovezfs ilovezfs closed this Aug 29, 2017
@DomT4
Copy link
Contributor Author

DomT4 commented Aug 29, 2017

I mean, you could've just asked me to change this PR back to a simple version bump rather than closing it completely 😄.

@ilovezfs ilovezfs reopened this Aug 29, 2017
@ilovezfs
Copy link
Contributor

Go for it.

@DomT4
Copy link
Contributor Author

DomT4 commented Aug 29, 2017

💁‍♂️

@ilovezfs
Copy link
Contributor

🎉

@ilovezfs
Copy link
Contributor

3.23 is out.

@ilovezfs
Copy link
Contributor

ENV["LC_ALL"] = "en_US.UTF-8" fixes the test.

@DomT4 DomT4 changed the title thefuck 3.22 thefuck 3.23 Aug 29, 2017
@ilovezfs
Copy link
Contributor

It looks like we're out-of-luck with the python3 thing as it prints a big ol' nasty warning unless we were to patch the warning out, which would be spitting in the wind :(

So yeah ... python3 it is. Sorry to have you chasing your tail like a 🐶.

@ilovezfs
Copy link
Contributor

I'm confused why the test is still failing. That seemed to fix it locally …

@DomT4
Copy link
Contributor Author

DomT4 commented Aug 29, 2017

Sorry to have you chasing your tail like a 🐶

🙈 🙈 🙈 🙈 🙈.

That seemed to fix it locally

Aye. I didn't have any problems locally in the first place, and still don't, but my LC_ALL is set to en_US.UTF-8 in shell already.

@ilovezfs ilovezfs closed this in 9b06ce2 Aug 29, 2017
@ilovezfs
Copy link
Contributor

Thousands of more python3 installations here we come … 🐍 🐍 🐍 🙈

@DomT4 DomT4 deleted the thefuck branch August 29, 2017 12:00
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants