Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Fully deprecates
dolt sql-client
by removing the CLI command.Resolves: Deprecate
dolt sql-client
dolthub/dolt#6886Previously sql-server.lock served two purposes: (1) attempt to keep two sql-server's from running against a Dolt database at the same time and (2) allow the Dolt binary to work seamlessly as a client when it was run against a Dolt database where a sql-server was already running locally. The previous implementation involved writing process state into multiple directories across the disk and checking that filesystem state against currently running processes in an attempt to choose the correct behavior for a given Dolt invocation.
This changes the sql-server.lock file to only be responsible for discovery in the second case. The first case is handled by querying the storage layer for any Dolt databases which will be served as part of a running sql-server. In order for the sql-server to start successfully, it must have exclusive write access to every Dolt database it will be serving.
dolt sql-server
is changed to only write the sql-server.lock file into the top-level data_dir of the running server. In exchange, all otherdolt
invocations which are looking for a running server are changed to look in successive parents of their data_dir in an attempt to find connection details for the running server.The
--ignore-lock-file
option is deprecated, but still successfully parsed and ignored to avoid needlessly breaking existing users.Original: Migrate AWS SDK for JavaScript v2 APIs to v3 dolthub/dolt#6948
This fixes one of the failures from Merging in a schema change can bypass constraint checks, causing panics or unrecoverable errors. dolthub/dolt#7034, but it's the more important one (the panic)
Before, we would panic when attempting to compute a merged row if that row would contain a null in a non-null column.
Now, we allow this row to be generated, and we validate it before merging it into the table.
Fixes Three Way Merging won't consider a row to have a data conflict if either side has the same binary rerpresentation as the base. dolthub/dolt#6746
This fixes a bug where the following situation fails to detect a conflict:
(1, 2)
(1, 2, NULL)
(1, 2, 3)
Bumps golang.org/x/image from 0.5.0 to 0.10.0.
Commits
cb227cd
tiff: limit work when decoding malicious imagesa5392f0
bmp: support to decode 8-bit format with up to 256 color palettef9550b0
go.mod: update golang.org/x dependencies81c166c
go.mod: update golang.org/x dependenciesed5dba0
go.mod: update golang.org/x dependencies08ca817
font: have Glyph return !ok for U+FFFD substituteb6ac75b
go.mod: update golang.org/x dependencies1b74412
font/sfnt: set type for all NameID constantsf632f7f
tiff, tiff/lzw, vector: use single space in comments[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/image&package-manager=go_modules&previous-version=0.5.0&new-version=0.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](/~https://github.com/dolthub/dolt/network/alerts).
go-mysql-server
flush binary logs
be noopfixes Support
flush binary logs
dolthub/dolt#7055The motivation for this PR is making the costing/exploration phase consistent with the data structures for index costing. That means switching memo
ScalarExpr
back tosql.Expression
. Moving the previously join-specific ids inScalarExpr
to tables and column refs lets us preserve most memo data structures and join transformation logic. The alternative to combining these changes would be to rewrite all of the memo data structures and transformation logic to not use ids, which would be a fairly long and difficult process.Change summary:
expression.GetField
has table and column ids nowsql.TableIdNode
to embed unique table ids and a range of source columns idssql.Expression
and the new idsMost of the diffs in this PR are from adding tables and column ids to DebugString and auto-changes to
expression.NewGetFieldWithTable
. The substantive changes are folded inplanbuilder
,memo.go
,rel_props.go
,indexed_joins.go
, andjoin_order_builder.go
.SetOp
,GroupBy
, andWindow
are 3 outliers that implementTableIdNode
but lack the ability to represent all of their expressions with id's. All expressions should eventually get ids, but we would only need a subset of expression types to have ids for this to work for these nodes (ex:GroupBy
's colset would be aggregate expressions and any passthrough GetFields). One customer that updates Dolt versions infrequently would see a couple HASH_JOIN fallback to INNER_JOIN until this is fixed.TODO
Dolt bump: [no-release-notes] Unique ids bump dolthub/dolt#7067
fixes Crash by SQRT dolthub/dolt#7060
Additionally, fixes
POW()
to not have the same panic and returns warnings instead of errors for certain inputs toLOG()
.nil
cast for time functionsfixes Crash by Time Functions dolthub/dolt#7056
update <table> set <column> = default
This PR fixes a bug where attempting to update a column to its default would throw an unresolved error.
DayName()
returnNULL
on badDATETIME
conversionsfixes Crash by Function DAYNAME dolthub/dolt#7039
Decorrelating IN_SUBQUERY into subquery aliases adds new relations to the query plans in a way that makes table and column identifier tracking difficult. So instead of converting
select * from xy where x in (select u from uv)
into a subquery alias join:This change is better in most places, but worse in instances when we cannot unnest now because the RHS equality expression is not a valid get field reference, for example when the subquery returns the value of a GROUP_BY or WINDOW or a synthesized alias (anything without a source column Id). This is fixable in the future.
This also fixes a few ANTI_JOIN problems that this refactor exposed.
Closed Issues
dolt sql-client
flush binary logs