Skip to content

Commit

Permalink
Pointcloud labeling improvement. Update three.js to the latest versio…
Browse files Browse the repository at this point in the history
…n. v1.3.0
  • Loading branch information
dmandrioli committed Jan 4, 2020
1 parent e5d86b2 commit f5eb9f8
Show file tree
Hide file tree
Showing 6 changed files with 239 additions and 206 deletions.
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ It supports images (.jpg or .png) and point clouds (.pcd).
It is a [Meteor](http://www.meteor.com) app developed with [React](http://reactjs.org),
[Paper.js](http://paperjs.org/) and [three.js](https://threejs.org/).

**New in version 1.2.0:** Support for binary and binary compressed point clouds (thanks @CecilHarvey)

**Breaking change in version 1.2.2:** Exported point cloud coordinates are no longer translated (thanks @hetzge)
**Latest changes**
- **Version 1.3:** Improve pointcloud labeling: bug fixes and performance improvement (labeling a 1M pointcloud is now possible)
- **Version 1.2.2:** Breaking change: exported point cloud coordinates are no longer translated (thanks @hetzge)
- **Version 1.2.0:** Support for binary and binary compressed point clouds (thanks @CecilHarvey)


## Bitmap Image Editor

Expand Down
3 changes: 3 additions & 0 deletions imports/common/SseMsg.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import postal from "postal";

export default class SseMsg {
static register(obj) {
if (obj.sendMsg){
return;
}
obj.actions = {};
obj.subscription = postal.subscribe({
channel: "ui",
Expand Down
4 changes: 2 additions & 2 deletions imports/editor/3d/GradientBoxHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function BoxHelper(object, color) {

var geometry = new BufferGeometry();
geometry.setIndex(new BufferAttribute(indices, 1));
geometry.addAttribute('position', new BufferAttribute(positions, 3));
geometry.setAttribute('position', new BufferAttribute(positions, 3));

var colors = [
.2, .2, .2, .2, .2, .2,
Expand All @@ -28,7 +28,7 @@ function BoxHelper(object, color) {
.8, .8, .8, .8, .8, .8,
.8, .8, .8, .8, .8, .8
];
geometry.addAttribute('color', new THREE.Float32BufferAttribute(colors, 3));
geometry.setAttribute('color', new THREE.Float32BufferAttribute(colors, 3));

const material = new THREE.LineBasicMaterial({vertexColors: 2});

Expand Down
Loading

0 comments on commit f5eb9f8

Please sign in to comment.