Field selection for simple compound types #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that h5pyd is trying to read more bytes than was actually sent. |
mattjala
force-pushed
the
cmpd_field_selection
branch
from
ac94574 to
bd6fdc3
Compare
mattjala
changed the title
This fixed the slowdown - this PR is ready for review now. |
jreadey
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently has a massive performance issue with field reads. Reading 144 bytes in a field selection takes over a minute. The stall occurs when
rsp.iter_contentis invoked inbase.py. Other calls that try to directly interact with the response, likersp.textorrsp.contenthave a similar delay.I tried manually specifying the
utf-8encoding for the response, since apparently having to try a bunch of encodings when one isn't specifying can sometimes cause slowdown like this, but it had no effect.