Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

[Duplicated] #37 #36

Closed
wants to merge 2 commits into from
Closed

Conversation

hexoul
Copy link
Contributor

@hexoul hexoul commented Jan 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #28

$ vvisp -v
error: unknown option `-v'
$ vvisp -version
error: unknown option `-v'
$ vvisp --version
0.1.9

What is the new behavior?

$ vvisp -v
v0.1.9
$ vvisp -version
v0.1.9
$ vvisp --version
v0.1.9

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Even if it was described as feature in #28, there are no tests because it is just version display.

@hexoul hexoul changed the title Fix version display about #28 Fix version display Jan 2, 2019
@JhChoy JhChoy added enhancement New feature or request docs About documentation labels Jan 2, 2019
@JhChoy JhChoy self-assigned this Jan 2, 2019
@JhChoy
Copy link
Contributor

JhChoy commented Jan 2, 2019

Thank you for the first contribute!
There is just one request.
Could you change the fix: update README for vvisp npm badge commit msg to docs: update README for vvisp npm badge please?
Then, I'll go on to merge :)

@hexoul hexoul closed this Jan 2, 2019
@hexoul hexoul deleted the version-display-#28 branch January 2, 2019 07:23
@hexoul
Copy link
Contributor Author

hexoul commented Jan 2, 2019

OMG I missed branch control. because of recreated branch, can't reopen it. Please see #37

@hexoul hexoul changed the title Fix version display [Duplicated] #37 Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs About documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants