Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

fix: fix default registry true => false #107

Merged
merged 1 commit into from
Mar 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vvisp/scripts/deploy-service/preProcess/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ module.exports = async function(deployState, options) {
}

// Check whether this process needs Registry
// Event occurs when user sets config.registry false
if (config.registry === false) {
// Event occurs when user sets config.registry false or does not set.
if (!config.registry) {
// User cannot use upgradeable patterns without registry
if (compileInformation.noProxy !== true) {
throw new Error(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"serviceName": "Haechi",
"registry": true,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0",
"value1": 1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"serviceName": "Haechi",
"registry": true,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0",
"value1": 1
Expand Down
1 change: 1 addition & 0 deletions packages/vvisp/test/dummy/justUpgradeables.service1.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"serviceName": "Haechi",
"registry": true,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0"
},
Expand Down
1 change: 1 addition & 0 deletions packages/vvisp/test/dummy/justUpgradeables.service2.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"serviceName": "Haechi",
"registry": true,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0"
},
Expand Down
1 change: 0 additions & 1 deletion packages/vvisp/test/dummy/noRegistry.service1.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"serviceName": "Haechi",
"registry": false,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0",
"value1": 1
Expand Down
1 change: 0 additions & 1 deletion packages/vvisp/test/dummy/noRegistry.service2.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"serviceName": "Haechi",
"registry": false,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0",
"value1": 1
Expand Down
1 change: 1 addition & 0 deletions packages/vvisp/test/dummy/service1.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"serviceName": "Haechi",
"registry": true,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0"
},
Expand Down
1 change: 1 addition & 0 deletions packages/vvisp/test/dummy/service2.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"serviceName": "Haechi",
"registry": true,
"variables" : {
"owner" : "0xb5F4E40c8177Ad63B19D4D3a254a5758771f57d0"
},
Expand Down
8 changes: 0 additions & 8 deletions packages/vvisp/test/dummy/test.env

This file was deleted.

2 changes: 1 addition & 1 deletion packages/vvisp/test/scripts/deploy-service/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function getWaitingTxNum() {
stateClone.notUpgrading = true;
stateClone.contracts = {};
stateClone.serviceName = config.serviceName;
if (config.registry === false) {
if (!config.registry) {
stateClone.registry = 'noRegistry';
} else {
resultNumber++; // registry
Expand Down