Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default container limits and concurrency value #31

Merged
merged 9 commits into from
May 17, 2022
Merged

Set default container limits and concurrency value #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
96c9585
Set default container limits and concurrency value
jmgreger Apr 7, 2022
d2de7f7
Update README.md
jmgreger Apr 7, 2022
fbe19d0
Merge pull request #1 from jmgreger/patch-2
jmgreger Apr 7, 2022
e871f1d
Fixed limits variable block
jmgreger Apr 7, 2022
578f4ad
variables.tf formatting
jmgreger Apr 7, 2022
8f4439d
terraform fmt
jmgreger Apr 19, 2022
4bcc110
generated docs
Apr 19, 2022
2647251
updates variables to null
May 13, 2022
c2d7e82
generated_docs
May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ module "cloud_run" {
| argument | Arguments passed to the ENTRYPOINT command, include these only if image entrypoint needs arguments | `list(string)` | `[]` | no |
| certificate\_mode | The mode of the certificate (NONE or AUTOMATIC) | `string` | `"NONE"` | no |
| container\_command | Leave blank to use the ENTRYPOINT command defined in the container image, include these only if image entrypoint should be overwritten | `list(string)` | `[]` | no |
| container\_concurrency | Concurrent request limits to the service | `number` | `0` | no |
| container\_concurrency | Concurrent request limits to the service | `number` | `null` | no |
| domain\_map\_annotations | Annotations to the domain map | `map(string)` | `{}` | no |
| domain\_map\_labels | A set of key/value label pairs to assign to the Domain mapping | `map(string)` | `{}` | no |
| env\_secret\_vars | [Beta] Environment variables (Secret Manager) | <pre>list(object({<br> name = string<br> value_from = set(object({<br> secret_key_ref = map(string)<br> }))<br> }))</pre> | `[]` | no |
| env\_vars | Environment variables (cleartext) | <pre>list(object({<br> value = string<br> name = string<br> }))</pre> | `[]` | no |
| force\_override | Option to force override existing mapping | `bool` | `false` | no |
| generate\_revision\_name | Option to enable revision name generation | `bool` | `true` | no |
| image | GCR hosted image URL to deploy | `string` | n/a | yes |
| limits | Resource limits to the container | `map(string)` | `{}` | no |
| limits | Resource limits to the container | `map(string)` | `null` | no |
| location | Cloud Run service deployment location | `string` | n/a | yes |
| members | Users/SAs to be given invoker access to the service | `list(string)` | `[]` | no |
| ports | Port which the container listens to (http1 or h2c) | <pre>object({<br> name = string<br> port = number<br> })</pre> | <pre>{<br> "name": "http1",<br> "port": 8080<br>}</pre> | no |
Expand Down
4 changes: 2 additions & 2 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ variable "template_annotations" {
variable "container_concurrency" {
type = number
description = "Concurrent request limits to the service"
default = 0
default = null
}

variable "timeout_seconds" {
Expand Down Expand Up @@ -125,7 +125,7 @@ variable "volumes" {
variable "limits" {
type = map(string)
description = "Resource limits to the container"
default = {}
default = null
}
variable "requests" {
type = map(string)
Expand Down